-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events: sender_type property to differentiate between multiple event sources #399
Events: sender_type property to differentiate between multiple event sources #399
Conversation
…t-source-of-change
All works good, but I have one note, enrolled events don't have sender type filled from headers and enroll endpoint does not allow to fill it. |
…t-source-of-change
Thanks. Good catch. I've added senderType to the request body and the enroll endpoint also supports providing sender and sender type values in headers. Both is optional, but when a value is specified both in the headers and the body, value from the body is used. |
Nope, you didn't 🙂 , enroll still without |
@iLLiCiTiT i ALMOST did. it was just one |
Endpoints that accepted "x-sender" header now also accept "x-sender-type".
sender_type is stored in the database in the separate field. and it is available in the eventmodel.
@jakubjezek001 @iLLiCiTiT do you need to be able to filter by it in enroll somehow? if so, how?