Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: Do not resolve all folders when uri contains just the project name #334

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Resolve: Do not resolve all folders when uri contains just the project name #334

merged 1 commit into from
Sep 3, 2024

Conversation

martastain
Copy link
Member

No description provided.

@martastain martastain linked an issue Sep 3, 2024 that may be closed by this pull request
Project URI resolve returns all the project folders #330
Closed
@martastain martastain added the type: bug Something isn't working label Sep 3, 2024
@martastain martastain self-assigned this Sep 3, 2024
@martastain martastain requested a review from Lypsolon September 3, 2024 12:50
Lypsolon
Lypsolon approved these changes Sep 3, 2024
View reviewed changes
Copy link

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic Testing works.
changes also give me no reason why it should cause problems.

sooooo i Approve.

@BigRoy
Copy link
Contributor

BigRoy commented Sep 3, 2024

Couldn't that resolve to the project entity instead? Or is that not a sensible entity to begin with?

@martastain
Copy link
Member Author

martastain commented Sep 3, 2024 •
edited
Loading

Couldn't that resolve to the project entity instead? Or is that not a sensible entity to begin with?

It cannot. the result model is created for projectlevel entities (that have IDs) so it does not really makes sense. It would basically just for ayon://myproject return entities:[{"name": "myproject"}]

BigRoy
BigRoy approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. However, it always returning nothing kind of makes me feel we could just as well report an error - but hey, maybe empty responses is what everyone likes. 😎

@martastain martastain merged commit cb59024 into develop Sep 3, 2024
@martastain martastain deleted the 330-project-uri-resolve-returns-all-the-project-folders branch October 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lypsolon Lypsolon Lypsolon approved these changes

@BigRoy BigRoy BigRoy approved these changes

Assignees

@martastain martastain

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project URI resolve returns all the project folders
3 participants
@martastain @BigRoy @Lypsolon