-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: Migrate settings based on bundle #326
Settings: Migrate settings based on bundle #326
Conversation
Could you elaborate on this? Would it never work if an addon doesn't specify a certain function? Or it would just be unable to resolve conflicts using use a migration method if version mismatches would have mismatching settings. And when saying "mismatching settings". Is that, incompatible settings, like a type changing? Or if e.g. a setting was removed or added would it also fail? |
If the model changes fields in an incompatible way such as It should however handle simpler changes such as |
…based-on-the-bundle
PR Checklist
Testing
Phase 1: Test migrateSettingsByBundle endpoint
OldBundle
bundle with an older version of an addon and change its studio and project settingsNewBundle
bundle with a newer version of the same addon and keep it untouchedOldBundle
to production andNewBundle
to stagingCall (using postman, curl or httpie) a
[POST]
request with administrator or service privileges to/api/migrateSettingsByBundle
with the following JSON payloadCheck the logs for errors.
Failed to validate XXXX with value XXX
warnings are expected if the target addon does not have migration method in place. that setting won't be migrated.Ensure the settings were correctly propagated in studio settings and project settings
When Settings: copy project settings when promoting a bundle #311 is merged, use "promote bundle" function on the staging bundle and ensure site settings were also migrated