Settings: Improved SettingsField #305
Merged
+237
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martastain
added
the
type: enhancement
martastain
changed the title
iLLiCiTiT
reviewed
Aug 8, 2024
iLLiCiTiT
approved these changes
Aug 8, 2024
Co-authored-by: Jakub Trllo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SettingsFieldis no longer just an alias topydantic.Fieldbut reimplements it and provides type checking for all additional types used in settings. **kwargs is now used just for backward compatibility (preventing raising errors, instead it logs a message about unsupported argument passed)