Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: fix version argument parsing #304

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Resolve: fix version argument parsing #304

merged 4 commits into from
Aug 1, 2024

Conversation

martastain
Copy link
Member

@martastain martastain commented Aug 1, 2024 •
edited by BigRoy
Loading

Fixes support for entity URIs that do not have v prefixed to the version number in the URI.

This now supports:

ayon+entity://demo_Big_Feature/assets/environments/01_pfueghtiaoft?product=layoutMain&version=4&representation=ma

But should also still support:

ayon+entity://demo_Big_Feature/assets/environments/01_pfueghtiaoft?product=layoutMain&version=v004&representation=ma

Note the version values 4 instead of v004

Additional Context

Related to comment here ynput/ayon-usd#21 (comment)

@martastain martastain self-assigned this Aug 1, 2024
@martastain martastain requested a review from BigRoy August 1, 2024 11:21
BigRoy
BigRoy reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice - some small comments!

I've also changed your PR description to include some information.

api/resolve/__init__.py Outdated Show resolved Hide resolved
api/resolve/__init__.py Outdated Show resolved Hide resolved
BigRoy
BigRoy reviewed Aug 1, 2024
View reviewed changes
api/resolve/__init__.py Outdated Show resolved Hide resolved
BigRoy
BigRoy approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how to test this PR - but the code changes make sense.

@BigRoy
Copy link
Contributor

BigRoy commented Aug 1, 2024 •
edited
Loading

Tagging @mkolar @dee-ynput for visibility to double check whether version=1 should be valid inside a ayon entity URI as opposed to requiring the version name to be prefixed with v.

With this PR version=1 and version=v001 (and version=001) works the same way. Previously only v001 would work.

@BigRoy BigRoy mentioned this pull request Aug 1, 2024
Merged
23 tasks
@martastain martastain merged commit 37b6cc0 into develop Aug 1, 2024
@martastain martastain added the type: bug Something isn't working label Aug 6, 2024
@martastain martastain deleted the resolve-fix-version-conditions branch October 21, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

Assignees

@martastain martastain

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martastain @BigRoy