Activity feed: notify clients when an activity is created, updated or deleted #257
+121
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martastain
added
the
type: enhancement
martastain
changed the title
martastain
changed the title
|
A user can receive a message from a project they do not have access to.
|
|
Hmmm. True, but there's not much they can do with that. As the message does not contain any data, just a bunch of IDs. It would be nice to filter out messages by access rights tho. I could do that in the websocket module as i hold metadata of connected users. But i think that's out of the scope of this PR. creating a second issue for it. |
projectName is sensitive |
|
Oh. Yes. I'll start working on it. |
martastain
deleted the
237-activity-feed-ws-message-on-new-activity-feed-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an activity is created RT
activity.createdevent is dispatched with a list of all affected entities. that should trigger cache invalidation of the activity feed.Keep in mind, that sender matching will prevent originating browser tab receiving the message, so whoever creates the activity is responsible to invalidate their own cache.
Don't forget subscribing to
activity.createdtopic.(the same structure is used for
activity.updatedandactivity.deletedtopics