Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Update default hero publish template to include frame and udim #252

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jun 19, 2024

PR Checklist

  • This comment contains a description of changes
  • Referenced issue is linked

Description of changes

Update default hero template to contain match default publish template but with version swapped to hero

Technical details

It's good to be aware that this may introduce more complexities because with hero version publishes it may be the case that previous hero versions had different frames and as such, it may occur that 'frames' that should not be there anymore do not actually belong to the new version - same goes for UDIMs.

What becomes worse then is if e.g. a path set inside a DCC just happens to be referring to e.g. a start frame of the hero that's not supposed to be there in the new version. Which means you're basically potentially losing the 'static' nature of what a hero version tries to be? This is why I'm creating this as DRAFT since that may need to be taken seriously.

NOTE: This PR also replaces task name in the filename to product name to align with default regular publish template because it seemed odd that those differed - but maybe there were reasons to have that task name instead of product name for hero files?

Additional context

This has come up before as an issue here:

A potential error that would be hit, is e.g. this:

DEBUG: --- Integration of Hero version for product `pointcacheGeo` begins.
DEBUG: Looking for matching profile for: hosts: "houdini" | product_types: "pointcache" | task_names: "modeling" | task_types: "Modeling"
DEBUG: "houdini" not found in "hosts": ['standalonepublisher']
DEBUG: None of profiles match your setup. hosts: "houdini" | product_types: "pointcache" | task_names: "modeling" | task_types: "Modeling"
DEBUG: `hero` template check was successful. `{root[work]}/{project[name]}/{hierarchy}/{folder[name]}/publish/{product[type]}/{product[name]}/hero/{project[code]}_{folder[name]}_{task[name]}_hero<_{comment}>.{ext}`
DEBUG: hero publish dir: "C:\projects\ayontest\asset\char_hero\publish\pointcache\pointcacheGeo\hero"
DEBUG: http://localhost:5000 "POST /graphql HTTP/1.1" 200 105
DEBUG: Response <RestApiResponse [200]>
DEBUG: Creating first hero version.
ERROR: !!! Creating of hero version failed. Previous hero version maybe lost some data!
Traceback (most recent call last):
  File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2403061937_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "E:\dev\ayon-core\client\ayon_core\plugins\publish\integrate_hero_version.py", line 127, in process
    self.integrate_instance(
  File "E:\dev\ayon-core\client\ayon_core\plugins\publish\integrate_hero_version.py", line 390, in integrate_instance
    head, tail = _template_filled.split(frame_splitter)
ValueError: not enough values to unpack (expected 2, got 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant