Settings: Update default hero publish template to include frame and udim #252
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description of changes
Update default hero template to contain match default publish template but with version swapped to
hero
Technical details
It's good to be aware that this may introduce more complexities because with hero version publishes it may be the case that previous hero versions had different frames and as such, it may occur that 'frames' that should not be there anymore do not actually belong to the new version - same goes for UDIMs.
What becomes worse then is if e.g. a path set inside a DCC just happens to be referring to e.g. a start frame of the hero that's not supposed to be there in the new version. Which means you're basically potentially losing the 'static' nature of what a hero version tries to be? This is why I'm creating this as DRAFT since that may need to be taken seriously.
NOTE: This PR also replaces task name in the filename to product name to align with default regular publish template because it seemed odd that those differed - but maybe there were reasons to have that task name instead of product name for hero files?
Additional context
This has come up before as an issue here:
A potential error that would be hit, is e.g. this: