Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox: Websocket notification #226

Conversation

martastain
Copy link
Member

When a new activity is created, referenced users are notified using fire and forget websocket event with inbox.message topic.

The event uses the first line of the message body as its description summary.isImportant flag could be used to silence unimportant messages based on the user preferences.

@martastain martastain self-assigned this Jun 6, 2024
@martastain martastain requested a review from Innders June 6, 2024 09:21
@martastain martastain added the type: feature Adding something new and exciting to the product label Jun 6, 2024
Copy link
Member

@Innders Innders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that a user will receive the message even if the new inbox item is not relevant them and wouldn't end up in their inbox. We are receiving all messages for everyone.

@martastain martastain merged commit 1aada53 into develop Jun 6, 2024
@martastain martastain deleted the 222-notifications-when-a-new-inbox-item-is-available-send-to-user-over-ws branch June 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications: When a new inbox item is available send to user over WS
2 participants