REST API: Unify SiteID specifications #199
Merged
+121
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies site_id dependency across rest endpoints. Two dependencies
SiteID
andClientSiteID
are used as specified in the linked issue.Discussion & future
Endpoints
/api/projects/{project_name}/roots/{root_name}
still use site_id provided in path. This is inconsistent, but probably not worthed breaking the backwards compatibility./api/settings
still expect site id to be provided as a query argument. Should it also accept header option as it is called from the client application and site_id is by default sent with the request? or do we need granularity here and option to get just project settings? @iLLiCiTiTTesting