fix: don't make api calls if file has no extension

ymirapp · Sep 7, 2020 · b0d206a · b0d206a
1 parent 84d4bc1
commit b0d206a
Show file tree

Hide file tree

Showing 3 changed files with 116 additions and 104 deletions.
diff --git a/src/CloudStorage/CloudStorageStreamWrapper.php b/src/CloudStorage/CloudStorageStreamWrapper.php
@@ -672,7 +672,9 @@ private function getStat(string $key, array $details = [])
             12 => -1,     'blocks' => -1,
         ];
 
-        if (empty($key)) {
+        // Avoid doing API calls if the given object key has no extension. "wp_upload_dir" does a lot
+        // of file checks to create directories and that impacts performance significantly.
+        if (empty($key) || empty(pathinfo($key, PATHINFO_EXTENSION))) {
             return $stat;
         }