Fix compilation on linux/travis. #4
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about that, and thanks for fixing it. |
|
Actually I found out that @nebolsin has made many fixes to this library which would be great to merge. So maybe you should wait a bit with this pull request and see if he opens a pull request that fixes everything in one go. The only issue with his fork at the moment is that he didn't fix the OpenSSL >=1.1.0 issue yet, but maybe he will incorporate that as well. (Otherwise I will be willing to make a new pull request that merges this stuff.) |
|
Great, I saw some nice PR's on the other forks. Would be really nice to keep this mainline branch up to date and building without the dependencies that some of those have. Again, cool stuff 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest pull request by @socmag broke the build on travis CI (and on my machine) as seen here:
https://travis-ci.org/spatstat/s2-geometry-library/builds/287482806
A fix in CMakeLists.txt made it compile on osx on travis as seen here:
https://travis-ci.org/spatstat/s2-geometry-library/builds/287518806
Finally an issue with
isnanandisinfalready being defined for gcc/g++ needed to be fixed in exactfloat.cc for it to build on both platforms:https://travis-ci.org/spatstat/s2-geometry-library/builds/287530941