Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add path to types in exports definition in package.json #32

Closed
wants to merge 3 commits into from

Conversation

joelhooks
Copy link

This was breaking my build. It will require a patch version bump to make it function, but there are no changes outside of the package.json and it "just works"

microsoft/TypeScript#52363

There are types at '/Users/joel/Code/joelhooks/course-builder/apps/course-builder-web/node_modules/y-codemirror.next/dist/src/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'y-codemirror.next' library may need to update its package.json or typings.

microsoft/TypeScript#52363

> There are types at '/Users/joel/Code/joelhooks/course-builder/apps/course-builder-web/node_modules/y-codemirror.next/dist/src/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'y-codemirror.next' library may need to update its package.json or typings.
@dmonad
Copy link
Member

dmonad commented Jan 2, 2025

You got a duplicate types property in your branch now. Aside from that, we are all synced-up.

Sorry that I didn't use this PR. I overlooked it..

@dmonad dmonad closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants