Support views and foreign tables in yii\pgsql\Schema.findTableNames #7834
Conversation
|
Is it possible to add some tests for it? |
|
Sure, it's a good idea since I was wondering if there will be a difference between an ordinary and materialized view. |
|
I've added test but actually ran only sqlite and pgsql. I also found and fixed one bug in mssql tests introduced by dd15857, too much copy and paste and |
| @@ -177,8 +177,10 @@ protected function findTableNames($schema = '') | |||
| $schema = $this->defaultSchema; | |||
| } | |||
| $sql = <<<EOD | |||
| SELECT table_name, table_schema FROM information_schema.tables | |||
| WHERE table_schema=:schema AND table_type='BASE TABLE' | |||
| SELECT c.relname AS table_name | |||
There was a problem hiding this comment.
table_schema isn't selected anymore. Are you sure it's OK?
There was a problem hiding this comment.
It wasn't used.
samdark
changed the title
nineinchnick
force-pushed
the
7833-schema-views
branch
from
a3b25f2 to
5b30bfd
Compare
|
@samdark this one is also ready for merge |
|
Except changelog :) Also it seems there are conflicts with master now. |
…oes not include materialized views
nineinchnick
force-pushed
the
7833-schema-views
branch
from
5b30bfd to
d313517
Compare
|
@samdark done, but somehow I messed up the |
|
Merged 29304a1 Thanks! |
|
@nineinchnick the syntax is a bit unnatural: |
References #7833.