Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add csp nonce attribute to style tags (#20309) #20310

Merged

Conversation

nzwz
Copy link
Contributor

@nzwz nzwz commented Jan 14, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #20309
What attribute should be added to the style tag?

Only the nonce
Nonce use-case is easy to find in the API docs
Less flexible

@nzwz nzwz changed the title 20309 add csp nonce attribute to style tags (#20309) add csp nonce attribute to style tags (#20309) Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.15%. Comparing base (7565d33) to head (d45a4b5).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20310      +/-   ##
============================================
- Coverage     64.84%   60.15%   -4.70%     
- Complexity    11433    11435       +2     
============================================
  Files           431      431              
  Lines         37190    37192       +2     
============================================
- Hits          24117    22373    -1744     
- Misses        13073    14819    +1746     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark requested a review from a team January 14, 2025 10:25
@samdark samdark added this to the 2.0.53 milestone Jan 15, 2025
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Need a line for CHANGELOG.

@nzwz
Copy link
Contributor Author

nzwz commented Jan 20, 2025

👍 Need a line for CHANGELOG.

Thanks @samdark.

  • Add custom attributes support to style tags.

@nzwz nzwz force-pushed the 20309-add-csp-nonce-attribute-to-style-tags branch from 82bc0dc to 6ed004c Compare January 20, 2025 00:36
@samdark
Copy link
Member

samdark commented Jan 20, 2025

@nzwz nzwz force-pushed the 20309-add-csp-nonce-attribute-to-style-tags branch from 08bf334 to d45a4b5 Compare February 13, 2025 23:12
@nzwz
Copy link
Contributor Author

nzwz commented Feb 13, 2025

@samdark CHANGELOG updated, thanks.

@samdark samdark merged commit 4859c8f into yiisoft:master Feb 14, 2025
26 of 27 checks passed
@samdark
Copy link
Member

samdark commented Feb 14, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants