Fixes #15086 - window load inside ready state will not be triggered #15087
Conversation
alexantr
commented
Nov 3, 2017
•
alexantr
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes/no (for 7.1 stopped) |
| Fixed issues | #15086 |
alexantr
changed the title
| @@ -604,7 +604,7 @@ protected function renderBodyEndHtml($ajaxMode) | |||
| $lines[] = Html::script($js, ['type' => 'text/javascript']); | |||
| } | |||
| if (!empty($this->js[self::POS_LOAD])) { | |||
| $js = "jQuery(function ($) {\n$(window).on('load', function () {\n" . implode("\n", $this->js[self::POS_LOAD]) . "\n});\n});"; | |||
| $js = "jQuery(window).on('load', function () {\n" . implode("\n", $this->js[self::POS_LOAD]) . "\n});"; | |||
There was a problem hiding this comment.
Hmm... Shouldn't it be just "jQuery(function($) {\n" . implode("\n", $this->js[self::POS_LOAD]) . "\n});"?
There was a problem hiding this comment.
jQuery(function($) { }); - when DOM is ready
jQuery(window).on('load', function() { }); - when content is fully loaded
There was a problem hiding this comment.
I see that we are nesting the calls unnecessarily here but as far as I understand DOM ready event comes before window load event. if we register the handler inside of the DOM ready event, why does it have no effect?
There was a problem hiding this comment.
In version 3 the ready handler fires asynchronously.
You can check code:
jQuery(function ($) {
console.log('ready');
$(window).on('load', function () {
console.log('load in ready');
});
});
jQuery(window).on('load', function () {
console.log('load');
});With jQuery 2.2.4 you will see:
ready
load
load in ready
With jQuery 3.2.1 you will see:
load
ready
No "load in ready" anymore.
There was a problem hiding this comment.
I just wanted to make $ working even jQuery.noConflict() is enabled. But missed this great change in jQuery API. The best way to fix this bug - rollback my proposal in #14620
|
Merged: 2246786 |
|
Thank you! |
