Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] no assets #14832

Closed
wants to merge 2 commits into from
Closed

Conversation

schmunk42
Copy link
Contributor

Q A
Is bugfix? no
New feature? yes
Breaks BC? yes
Tests pass? ?

Detailed description will follow in: #8452

@klimov-paul
Copy link
Member

Simple removal of asserts requirement does not solve the issue.
Here you mention packages.json, which should replace them, but I can not see it.
Our current packages.json does not seem to me as full-scale replacement.

@schmunk42
Copy link
Contributor Author

The current packages.json contains only devDependencies, so there wouldn't been any packages installed needed during runtime.
I would not recommend to move the removed assets to packages.json here, but in a new repo, like yii2-widgets or yii2-grid...

@schmunk42
Copy link
Contributor Author

I just tried to play around with the recent code of 2.1, but it still contains bower-asset requirements. I think we should drop them and add the functionality later, most likely in another repo.

@samdark
Copy link
Member

samdark commented Jan 10, 2018

That is because JS was separated but wasn't yet moved out to separate repositories.

@schmunk42
Copy link
Contributor Author

@samdark
Copy link
Member

samdark commented Jan 10, 2018

It is along with tests.

@schmunk42
Copy link
Contributor Author

Tests for 7.1 in this PR have passed btw: https://travis-ci.org/yiisoft/yii2/jobs/276048104 - I actually wonder that they did, but anyway.

So the tests need to be moved also - for sure. How could we proceed with this?

@samdark
Copy link
Member

samdark commented Jan 10, 2018

If you want to handle it, I can grant you write permissions to https://github.com/yiisoft/yii2-jquery. Then:

  1. Got everything into yii2-jquery.
  2. Make sure travis/tests/docs/composer are OK.
  3. Clean up core framewrok.

@klimov-paul
Copy link
Member

@samdark, haveb't we agreed to use 'git subsplit' to transfer code from the core to extensions?
There is no sense of performing code separation until 2.0.14 release and 2.0.x freeze, since there will be need of merging code from 2.0.x to the 2.1.x.
Stay down - it is not the time yet.

@samdark
Copy link
Member

samdark commented Jan 10, 2018

We did. Right.

@schmunk42
Copy link
Contributor Author

Is it the time now? 😄

2.0.14 is released and "and 2.0.x will only receive bug fixes from now on. ".

Related: yiisoft/yii2-bootstrap#212

@klimov-paul
Copy link
Member

It is in the progress.
If you want to help, you may start from fixing NodeJs tests at yii2-jquery:
https://travis-ci.org/yiisoft/yii2-jquery/jobs/346919825

@schmunk42
Copy link
Contributor Author

Most tests are passing, see https://travis-ci.org/yiisoft/yii2-jquery/jobs/346996359 - I guess pjax can be removed and captcha also (move test to https://github.com/yiisoft/yii2-captcha)

PR: yiisoft/yii-jquery#1

@schmunk42
Copy link
Contributor Author

@schmunk42 schmunk42 closed this Feb 28, 2018
@klimov-paul klimov-paul added this to the 2.1.0 milestone Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants