-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1] no assets #14832
[2.1] no assets #14832
Conversation
Simple removal of asserts requirement does not solve the issue. |
The current |
I just tried to play around with the recent code of |
That is because JS was separated but wasn't yet moved out to separate repositories. |
Is is basically moving these files https://github.com/yiisoft/yii2/tree/2.1/framework/jquery into https://github.com/yiisoft/yii2-jquery or more? |
It is along with tests. |
Tests for 7.1 in this PR have passed btw: https://travis-ci.org/yiisoft/yii2/jobs/276048104 - I actually wonder that they did, but anyway. So the tests need to be moved also - for sure. How could we proceed with this? |
If you want to handle it, I can grant you write permissions to https://github.com/yiisoft/yii2-jquery. Then:
|
@samdark, haveb't we agreed to use 'git subsplit' to transfer code from the core to extensions? |
We did. Right. |
Is it the time now? 😄 2.0.14 is released and "and 2.0.x will only receive bug fixes from now on. ". Related: yiisoft/yii2-bootstrap#212 |
It is in the progress. |
Most tests are passing, see https://travis-ci.org/yiisoft/yii2-jquery/jobs/346996359 - I guess pjax can be removed and captcha also (move test to https://github.com/yiisoft/yii2-captcha) |
Closing, mostly obsolete due to https://github.com/yiisoft/yii2/issues/14862#issuecomment-369316223 |
Detailed description will follow in: #8452