Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phpunit dev-dependency #15512

Closed
schmunk42 opened this issue Jan 17, 2018 · 4 comments
Closed

Update phpunit dev-dependency #15512

schmunk42 opened this issue Jan 17, 2018 · 4 comments
Milestone
2.0.31

Comments

@schmunk42
Copy link
Contributor

What steps will reproduce the problem?

Run phpunit

What is the expected result?

No errors/warnings from PHPunit.

What do you get instead?

PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in /yii2/vendor/phpunit/phpunit/src/Util/Getopt.php on line 38

Additional info

Q A
Yii version 2.0.13
PHP version 7.2
Operating system Debian Linux

See also sebastianbergmann/phpunit#2887 (comment)

Are there special reasons why this is pinned to 4.8.34? The platform in composer.json also needs to be updated, I think. Is it 5.4, because this is the current minimum requirement?

How do you make tests run on Travis due to this (by disabling) deprecated warnings?
@samdark
Copy link
Member

samdark commented Jan 17, 2018

Are there special reasons why this is pinned to 4.8.34?

Maybe but I can't remember.

The platform in composer.json also needs to be updated, I think. Is it 5.4, because this is the current minimum requirement?

Yes.

How do you make tests run on Travis due to this (by disabling) deprecated warnings?

I think they just run... https://github.com/yiisoft/yii2/blob/master/tests/bootstrap.php#L8

@samdark samdark added this to the infrastructure milestone Jan 17, 2018
@rob006
Copy link
Contributor

rob006 commented Jan 17, 2018

See #14973

@samdark
Copy link
Member

samdark commented Jan 17, 2018

Alright. That is correct.

@schmunk42 schmunk42 mentioned this issue Jan 18, 2018
Closed
schmunk42 added a commit to yiisoft/yii2-docker that referenced this issue Jan 18, 2018
@schmunk42
updated framwork testing
99e4974 
- checkout framwork to /yii2 (host-volume)
- disable deprecated messages, see yiisoft/yii2#14973, yiisoft/yii2#15512
schmunk42 added a commit to schmunk42/yii2 that referenced this issue Jan 25, 2018
@schmunk42
use PHP 7.1 as a default on GitLab CI, see yiisoft#15512
0f7b1bf
samdark pushed a commit that referenced this issue Feb 5, 2018
@schmunk42 @samdark
Build image in dockerized tests with BUILD_ARG (#15559)
b9fc1f3 
* added build argument for Yii 2.0 PHP base image version
- streamlined build
- dropped network config for CI
- updated local test script

* added default for PHP (7.2) image on GitLab CI

* use PHP 7.1 as a default on GitLab CI, see #15512
@samdark samdark modified the milestones: infrastructure, 2.0.31 Dec 11, 2019
@samdark
Copy link
Member

samdark commented Dec 12, 2019

Won't do that because of backwards compatibility. Instead we have patching in place to make PHPUnit work well with recent versions of PHP.

@samdark samdark closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.31
Development

Successfully merging a pull request may close this issue.

updated phpunit and php-cs-fixer, removed php 5.4 from platform schmunk42/yii2
3 participants
@samdark @schmunk42 @rob006