Allow to prepare response outside of Request #40
Conversation
Hi! This change required to receive body data for PSR-7 response passing (not echo).
| */ | ||
| public function send() | ||
| public function send($return = false) |
There was a problem hiding this comment.
Now we have send() that does not send. :D
There was a problem hiding this comment.
It's a little confusing. Technically you send it but not in stdout but to the variable.
There was a problem hiding this comment.
Also logically it suppose to call events that you already have in send() when i requesting filled response...
There was a problem hiding this comment.
Aha. Then maybe process() that returns data? Then send() will look like echo process().
There was a problem hiding this comment.
@samdark that can work. What about events EVENT_BEFORE_SEND and EVENT_AFTER_SEND? Technically we sending content somewhere. Or these events apply only to stdout print?
I found $response->on(Response::EVENT_AFTER_SEND, [$this, 'cacheResponse']); in PageCache. If we dont call it when we working with RR cache will be newer generated.
There was a problem hiding this comment.
Actually PageCache will never work with PSR-7 server. It requesting data from ob_get_clean() which always will be empty. Or we rewrite it so it will collect data from Response, not ob_get_clean().
There was a problem hiding this comment.
Sending events should be called for sending only. We can add two additional events for processing. Roadrunner-like server and traditional server are two similar but different models so there may be need to do things a bit differently.
|
Goind to implement proper PSR usage. |
Hi!
This change required to receive body data for PSR-7 response passing (not echo).