Add rector [batch] (#3)

* Add rector files yiisoft/yii-dev-tool#232

* Add rector/rector dependecy

* [rector] Apply fixes

* Use predefined rector action

* Update src/FunctionalTester.php

Co-authored-by: rector-bot <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>

.github/workflows/rector.yml

@@ -0,0 +1,21 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+name: rector
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

composer.json

@@ -40,6 +40,7 @@
         "yiisoft/yii-runner-http": "^1.1"
     },
     "require-dev": {
+        "rector/rector": "^0.14.3",
         "roave/infection-static-analysis-plugin": "^1.16",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.18"

rector.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\LevelSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ]);
+
+    // register a single rule
+    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
+
+    // define sets of rules
+    $rectorConfig->sets([
+        LevelSetList::UP_TO_PHP_80,
+    ]);
+};

src/FunctionalTester.php

@@ -52,8 +52,6 @@ public function doRequest(string $method, string $url): ResponseInterface
     }
 
     /**
-     * @psalm-return ContainerInterface
-     * @return ContainerInterface
      * @psalm-suppress NullableReturnStatement
      */
     public function getContainer(): ContainerInterface

src/TestApplicationRunner.php

@@ -26,7 +26,6 @@ final class TestApplicationRunner extends ApplicationRunner
      * @var ServiceProviderInterface[]
      */
     private array $providers = [];
-    protected string $definitionEnvironment;
 
     /**
      * @param string $rootPath The absolute path to the project root.
@@ -38,12 +37,11 @@ public function __construct(
         string $rootPath,
         bool $debug,
         ?string $environment,
-        string $definitionEnvironment = 'web',
+        protected string $definitionEnvironment = 'web',
     ) {
         parent::__construct($rootPath, $debug, $environment);
         $this->bootstrapGroup = 'bootstrap-web';
         $this->eventsGroup = 'events-web';
-        $this->definitionEnvironment = $definitionEnvironment;
     }
 
     /**