Add rector [batch]

.github/workflows/rector.yml

@@ -0,0 +1,21 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+name: rector
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

composer.json

@@ -31,12 +31,13 @@
         "httpsoft/http-message": "^1.0.9",
         "php-http/guzzle7-adapter": "^1.0",
         "phpunit/phpunit": "^9.5",
+        "rector/rector": "^0.14.3",
         "roave/infection-static-analysis-plugin": "^1.16",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.18",
         "yiisoft/error-handler": "^2.1",
-        "yiisoft/yii-event": "^1.0",
-        "yiisoft/yii-console": "^1.0"
+        "yiisoft/yii-console": "^1.0",
+        "yiisoft/yii-event": "^1.0"
     },
     "suggest": {
         "yiisoft/yii-console": "Add error catching to console application",

rector.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\LevelSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ]);
+
+    // register a single rule
+    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
+
+    // define sets of rules
+    $rectorConfig->sets([
+        LevelSetList::UP_TO_PHP_80,
+    ]);
+};

tests/ConfigTest.php

@@ -24,9 +24,11 @@
 use Sentry\SentrySdk;
 use Sentry\Transport\HttpTransport;
 use Sentry\Transport\NullTransport;
+use Symfony\Component\Console\Event\ConsoleErrorEvent;
 use Yiisoft\Definitions\Reference;
 use Yiisoft\Di\Container;
 use Yiisoft\Di\ContainerConfig;
+use Yiisoft\Yii\Sentry\SentryConsoleHandler;
 
 final class ConfigTest extends TestCase
 {
@@ -137,8 +139,8 @@ public function eventsConsoleDataProvider(): array
                     ],
                 ],
                 [
-                    'Symfony\Component\Console\Event\ConsoleErrorEvent' => [
-                        ['Yiisoft\Yii\Sentry\SentryConsoleHandler', 'handle'],
+                    ConsoleErrorEvent::class => [
+                        [SentryConsoleHandler::class, 'handle'],
                     ],
                 ],
             ],

tests/SentryConsoleHandlerTest.php

@@ -4,6 +4,8 @@
 
 namespace Yiisoft\Yii\Sentry\Tests;
 
+use PHPUnit\Framework\Error\Error as PHPUnitError;
+use RuntimeException;
 use Symfony\Component\Console\Event\ConsoleErrorEvent;
 use Symfony\Component\Console\Input\StringInput;
 use Symfony\Component\Console\Output\NullOutput;
@@ -30,7 +32,7 @@ public function testHandleWithException(): void
 
 
         $this->createAndRunAppWithEventHandler($eventKey, ExceptionCommand::class);
-        $this->assertTransportHasException('RuntimeException', 'Console exception test.', $eventKey);
+        $this->assertTransportHasException(RuntimeException::class, 'Console exception test.', $eventKey);
     }
 
     public function testHandleWithFatalError(): void
@@ -39,7 +41,7 @@ public function testHandleWithFatalError(): void
         $eventKey = self::class . "::$methodName()";
 
         $this->createAndRunAppWithEventHandler($eventKey, FatalErrorCommand::class);
-        $this->assertTransportHasException('PHPUnit\Framework\Error\Error', 'Console fatal error test.', $eventKey);
+        $this->assertTransportHasException(PHPUnitError::class, 'Console fatal error test.', $eventKey);
     }
 
     public function testHandleWithErrorHandlerException(): void

tests/SentryMiddlewareTest.php

@@ -7,6 +7,7 @@
 use Error;
 use HttpSoft\Message\Response;
 use HttpSoft\Message\ServerRequest;
+use PHPUnit\Framework\Error\Error as PHPUnitError;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\RequestHandlerInterface;
@@ -32,7 +33,7 @@ public function testProcessWithException(): void
                 $this->createRequestHandlerWithException(),
             );
         } catch (RuntimeException $e) {
-            $this->assertTransportHasException('RuntimeException', 'Exception test.', $eventKey);
+            $this->assertTransportHasException(RuntimeException::class, 'Exception test.', $eventKey);
 
             throw $e;
         }
@@ -53,7 +54,7 @@ public function testProcessWithFatalError(): void
                 $this->createRequestHandlerWithFatalError(),
             );
         } catch (Error $e) {
-            $this->assertTransportHasException('PHPUnit\Framework\Error\Error', 'Fatal error test.', $eventKey);
+            $this->assertTransportHasException(PHPUnitError::class, 'Fatal error test.', $eventKey);
 
             throw $e;
         }