Draft yiisoft/view assets, and view no merge.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Tests pass?	✔️
Fixed issues	#49

[terabytesoftw]

[x] AssetBundleTest. Done.
[-] AssetConverterTest. In process.
[x] ThemeTest. Fixed.
[x] ViewTest. Fixed.
[x] WebViewTest. Fixed.
[-] Widgets . In process: Are we going to keep the widgets configuration type array ?

If you can fix the travis configuration.

Thks,

[samdark]

In process: Are we going to keep the widgets configuration type array ?

I was thinking about alternatives but haven't found better ones yet :( If you have any ideas, feel free to post them for discussion.

There is interesting forum discussion about Html helper https://forum.yiiframework.com/t/using-functions-for-html-generation/126814/24 with the idea of having $this-> style of view plugins. Not sure it suits widgets though.

Also, instead of config, config-methods could be used to make configuration in IDEs more handy.

If you can fix the travis configuration.

It is not broken as far as I can see.

[terabytesoftw]

I honestly believe that we should maintain the array configuration in the widgets and static helpers, I think that injecting everything through the container di would be equal to Yii2, in my opinion the views are only the representation of the result, and using static helpers would be fine, for on the other hand we would leave things like Yii2 like helpers and widgets that do not need a great design, I was reviewing the OptionsResolver Component of Symfony, it could be a good alternative to better control the matrix configurations.

And with respect to travis it was if the configuration of .travis.yml was already standardized.

[terabytesoftw]

We should create a repository of exceptions, we need to have more specific exceptions, those of php are very generic.

What is the replacement for:

Yii::debug(), Yii::error()

I can update the configuration of .travis.yml to that of Yiisoft/Template

Please Add repo scrutinizer, coverage tests AssetBundle (100%), AssetConverter (94%),

Thks,

[samdark]

We should create a repository of exceptions, we need to have more specific exceptions, those of php are very generic.

Create ones you need right in this repository.

What is the replacement for:
Yii::debug(), Yii::error()

1. Require "psr/log": "^1.1", in composer.json.
2. Type-hint against Psr\Log\LoggerInterface $logger.
3. $this->logger->error(), $this->logger->debug()

I can update the configuration of .travis.yml to that of Yiisoft/Template

Please do.

[samdark]

Please Add repo scrutinizer, coverage tests AssetBundle (100%), AssetConverter (94%),

Done.

[terabytesoftw]

@samdark What do you think about injecting the aliases and assetconverter into the bundle __construct() to use it in the same bundle.

Example:

<?php
/**
 * @link http://www.yiiframework.com/
 * @copyright Copyright (c) 2008 Yii Software LLC
 * @license http://www.yiiframework.com/license/
 */

namespace Yiisoft\Yii\Bootstrap4;

use Yiisoft\Aliases\Aliases;
use Yiisoft\Asset\AssetBundle;
use Yiisoft\Asset\AssetConverter;

/**
 * Asset bundle for the Twitter bootstrap css files.
 *
 * @author Qiang Xue <[email protected]>
 */
class BootstrapAsset extends AssetBundle
{
    public $sourcePath = '@npm/bootstrap/scss';

    public $css = [
        'bootstrap.css',
    ];

    public $publishOptions = [
        'only' => [
            'bootstrap.css',
            'bootstrap.css.map',
        ],
    ];

    public function __construct(Aliases $aliases, AssetConverter $assetConverter)
    {
        $assetConverter->commands['scss'] = [
            'css', 'sass {from} {to}'
        ];
        $assetConverter->convert('bootstrap.scss', $aliases->get('@npm/bootstrap/scss'));
    }
}

Review the documentation please.

[samdark]

I was always looking at bundles as configuration containers, not as anything that actively does things.

[terabytesoftw]

It is correct but to access the converter you will have to call it from the controller, and do the conversions, I think it is a good idea in the bundle, since it is converted to publish, on the other hand I would also agree if that task is left that the developer do it on your own using sass, gulp, and any tool for it.

[samdark]

Conversion may happen in many ways. Yii 2 has two out of the box ways for it:

1. By asset manager in the web app.
2. By console command that was combining/compressing assets.

Additionally community developed tools that generated configs for grunt/gulp and other native JavaScript builders from bundles.

I think it would be a bad idea to force specific way of conversion in the bundle itself because of that.

[terabytesoftw]

For widgets we must continue with the configuration of arrays since we must allow them to be easy to configure and can be changed dynamically.

Example:

/**
  * @var array $widgetOptions
  */
private $widgetOptions = [
    'setId()',
    'setItems()',
 ];

/**
 * setConfig widget options.
 *
 * @param array $config
 *
 * @throws \InvalidConfigException
 *
 * @return void
 */
public function setConfig(array $config): void
{
    foreach ($config as $key => $item) {
        if (in_array($key, $this->widgetOptions)) {
            $this->$key($config['$key']);
        } else {
            throw new \InvalidConfigException("Widget options: ($key) no exist.");
        }
    }
}

protected function setId(string $value): void
{
    $this->id = $value;
}

And we change the init() method to beforeRun()

[samdark]

@terabytesoftw is it overall ready for thorough review? Any things that should be done before that?

[terabytesoftw]

AssetBundle, AssetManager and AssetConverter work well I have tried them I am happy with that, now I would also like to fix the widgets and leave the complete operating package, of course you also have to fix i18n to establish everything well.

[samdark]

How about doing that in subsequent pull request? This one's diff is already close to impossible to review (but I can handle that).

[terabytesoftw]

How about doing that in subsequent pull request? This one's diff is already close to impossible to review (but I can handle that).

Done.

[samdark]

It is still valid AssetBundle publishes itself with the help of asset manager. Maybe asset manager should do it completely?