add functions [filterPath(), normalizeOptions(), copyDirectory()]

[terabytesoftw]

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌
Tests pass?	✔️
Fixed issues	(#4)

[samdark]

Looks OK to me now. Do you plan more changes?

[terabytesoftw]

We will review all possible use cases that we can have with the copyDirectory () and filterPath () from the AssetManager and based on those uses we will debug the filtering function well and know exactly what it returns for each case, Please do not merge.

[terabytesoftw]

Please check the code and tests, add 3 cases of only and except, and it works perfect, remove the filter option within filterPath, it had no use there, filterPath is only used for copyDirectory(), only and except are sufficient to filter in copyDirectory().

I think that using well only and except you can delete beforeCopy() and afterCopy(), it's just an opinion.

[terabytesoftw]

On the other hand I have been trying to raise the coverage to the tests but for example:

        if (!is_dir($directory)) { // double check if it does not exist
            return;
        }

        if (!empty($options['traverseSymlinks']) || !is_link($directory)) {
            if (!($handle = opendir($directory))) { // double check if it does not exist
                return; // It will never run.
            }
            while (($file = readdir($handle)) !== false) {
                if ($file === '.' || $file === '..') {
                    continue;
                }
                $path = $directory . '/' . $file;
                if (is_dir($path)) {
                    self::removeDirectory($path, $options);
                } else {
                    self::unlink($path);
                }
            }
            closedir($handle);
        }

Solution:

    if (!empty($options['traverseSymlinks']) || !is_link($directory)) {
        if (!($handle = @opendir($directory))) {  //@ avoid the exception https://www.php.net/manual/es/function.opendir.php
            return; // if it runs
        }

        while (($file = readdir($handle)) !== false) {
            if ($file === '.' || $file === '..') {
                continue;
            }
            $path = $directory . '/' . $file;
            if (is_dir($path)) {
                self::removeDirectory($path, $options);
            } else {
                self::unlink($path);
            }
        }

        closedir($handle);
    }

[terabytesoftw]

Already fix all the phpdocs of FileHelperTest, and try to simplify and improve FileHelper, the Yii2 code works perfect, it is the only utility that copies, and allows filtering and excepting files in github.

[samdark]

Seems to be OK now. Anything else you want in?

[terabytesoftw]

Seems to be OK now. Anything else you want in?

What do you think of creating BaseFileHelper as in Yii2, or creating a new FilterHelper.php, and passing the filtering classes there and lowering the cognitive complexity of FileHelper.php that scrutinizer punishes heavily, those filters are only used by the copyDirectory() function.

[samdark]

I see no need for Base*Helper.

those filters are only used by the copyDirectory () function

Then I see no reason to have them in a separate helper.

[terabytesoftw]

Ok then for my part everything is ready too.

[samdark]

Merged. Thank you!