Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] nikic/php-parser #22

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[WIP] nikic/php-parser #22

wants to merge 4 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jan 22, 2023

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

@samdark
Copy link
Member

samdark commented Jun 30, 2023

@xepozz what's the plan on this one?

@xepozz
Copy link
Member Author

xepozz commented Jun 30, 2023

It was for made for performance test comparasion. Current solution faster.

@xepozz
Copy link
Member Author

xepozz commented Jun 30, 2023

But php-parser 5 is coming, need to compare with it also

@samdark
Copy link
Member

samdark commented Jun 30, 2023

OK. Keeping it open for now.

@rustamwin rustamwin mentioned this pull request Sep 22, 2023
Open
@samdark
Copy link
Member

samdark commented Jul 16, 2024

@xepozz would you please re-compare it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xepozz @samdark @StyleCIBot