-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config to di instead of di-web #135
Conversation
Gerych1984
commented
Jan 15, 2024
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Fixed issues | #132 |
15d5140
to
7be6b7d
Compare
Moving di-web to di means you want to have it also in console runs. Is it so? What use case do you have? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Need line in changelog only
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 98.48% 98.48%
Complexity 262 262
=========================================
Files 10 10
Lines 658 658
=========================================
Hits 648 648
Misses 10 10 ☔ View full report in Codecov by Sentry. |
2d50ea8
to
22d12a8
Compare
Done |
👍 |