Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config to di instead of di-web #135

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

Gerych1984
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
Fixed issues #132

@xepozz
Copy link
Member

xepozz commented Jan 15, 2024

Moving di-web to di means you want to have it also in console runs. Is it so? What use case do you have?

@Gerych1984
Copy link
Contributor Author

Moving di-web to di means you want to have it also in console runs. Is it so? What use case do you have?

#132

@samdark samdark requested a review from vjik January 16, 2024 10:32
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Need line in changelog only

.github/workflows/bc.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/composer-require-checker.yml Outdated Show resolved Hide resolved
.github/workflows/mutation.yml Outdated Show resolved Hide resolved
.github/workflows/static.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a81dd12) 98.48% compared to head (22d12a8) 98.48%.

❗ Current head 22d12a8 differs from pull request most recent head e64dcf7. Consider uploading reports for the commit e64dcf7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #135   +/-   ##
=========================================
  Coverage     98.48%   98.48%           
  Complexity      262      262           
=========================================
  Files            10       10           
  Lines           658      658           
=========================================
  Hits            648      648           
  Misses           10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gerych1984
Copy link
Contributor Author

Looks good 👍 Need line in changelog only

Done

@samdark samdark merged commit 8ea8b54 into yiisoft:master Jan 22, 2024
19 of 21 checks passed
@samdark
Copy link
Member

samdark commented Jan 22, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants