fix rstudio/rmarkdown#2526 by reverting bebf117 since the cairo_pdf…

… device has been explicitly supported in chunk_device(); now all possible `pdf()` arguments are supported, including `family`
yihui · Oct 31, 2023 · c520211 · c520211
1 parent ce8cf77
commit c520211
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: knitr
 Type: Package
 Title: A General-Purpose Package for Dynamic Report Generation in R
-Version: 1.45.2
+Version: 1.45.3
 Authors@R: c(
     person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666")),
     person("Abhraneel", "Sarma", role = "ctb"),

diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,8 @@
 
 - `write_bib()` generated empty entries for packages without URLs (thanks, @bastistician, #2304).
 
+- The `family` argument was not passed to the `pdf` device (thanks, @sebkopf, rstudio/rmarkdown#2526).
+
 # CHANGES IN knitr VERSION 1.45
 
 ## NEW FEATURES

diff --git a/R/block.R b/R/block.R
@@ -414,7 +414,7 @@ chunk_device = function(options, record = TRUE, tmp = tempfile()) {
   } else if (identical(getOption('device'), pdf_null)) {
     if (!is.null(dev.args)) {
       dev.args = get_dargs(dev.args, 'pdf')
-      dev.args = dev.args[intersect(names(dev.args), c('pointsize', 'bg'))]
+      dev.args = dev.args[intersect(names(dev.args), names(formals(pdf)))]
     }
     do.call(pdf_null, c(list(width = width, height = height), dev.args))
   } else dev.new(width = width, height = height)