Skip to content

Commit

Permalink
[Enhancement] (nereids)implement showStorageEnginesCommand in nereids (
Browse files Browse the repository at this point in the history
…apache#43135)

Issue Number: close apache#42734
  • Loading branch information
Vallishp authored Nov 16, 2024
1 parent 6d62db5 commit d2473ce
Show file tree
Hide file tree
Showing 7 changed files with 144 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ supportedShowStatement
| SHOW REPOSITORIES #showRepositories
| SHOW ROLES #showRoles
| SHOW PROC path=STRING_LITERAL #showProc
| SHOW STORAGE? ENGINES #showStorageEngines
| SHOW CREATE MATERIALIZED VIEW mvName=identifier
ON tableName=multipartIdentifier #showCreateMaterializedView
;
Expand Down Expand Up @@ -255,7 +256,6 @@ unsupportedShowStatement
| SHOW FULL? TRIGGERS ((FROM | IN) database=multipartIdentifier)? wildWhere? #showTriggers
| SHOW EVENTS ((FROM | IN) database=multipartIdentifier)? wildWhere? #showEvents
| SHOW PLUGINS #showPlugins
| SHOW STORAGE? ENGINES #showStorageEngines
| SHOW BRIEF? CREATE TABLE name=multipartIdentifier #showCreateTable
| SHOW CREATE VIEW name=multipartIdentifier #showCreateView
| SHOW CREATE MATERIALIZED VIEW name=multipartIdentifier #showMaterializedView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@
import org.apache.doris.nereids.DorisParser.ShowProcedureStatusContext;
import org.apache.doris.nereids.DorisParser.ShowRepositoriesContext;
import org.apache.doris.nereids.DorisParser.ShowRolesContext;
import org.apache.doris.nereids.DorisParser.ShowStorageEnginesContext;
import org.apache.doris.nereids.DorisParser.ShowVariablesContext;
import org.apache.doris.nereids.DorisParser.ShowViewContext;
import org.apache.doris.nereids.DorisParser.SimpleColumnDefContext;
Expand Down Expand Up @@ -445,6 +446,7 @@
import org.apache.doris.nereids.trees.plans.commands.ShowProcedureStatusCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowRepositoriesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowRolesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowStorageEnginesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowVariablesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowViewCommand;
import org.apache.doris.nereids.trees.plans.commands.UnsetDefaultStorageVaultCommand;
Expand Down Expand Up @@ -4097,6 +4099,11 @@ public LogicalPlan visitShowProc(ShowProcContext ctx) {
return new ShowProcCommand(path);
}

@Override
public LogicalPlan visitShowStorageEngines(ShowStorageEnginesContext ctx) {
return new ShowStorageEnginesCommand();
}

@Override
public LogicalPlan visitShowCreateMaterializedView(ShowCreateMaterializedViewContext ctx) {
List<String> nameParts = visitMultipartIdentifier(ctx.tableName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ public enum PlanType {
SHOW_PROC_COMMAND,
SHOW_REPOSITORIES_COMMAND,
SHOW_ROLE_COMMAND,
SHOW_STORAGE_ENGINES_COMMAND,
SHOW_VARIABLES_COMMAND,
SHOW_AUTHORS_COMMAND,
SHOW_VIEW_COMMAND,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package org.apache.doris.nereids.trees.plans.commands;

import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.nereids.trees.plans.PlanType;
import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.ShowResultSet;
import org.apache.doris.qe.ShowResultSetMetaData;
import org.apache.doris.qe.StmtExecutor;

import com.google.common.collect.Lists;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.util.List;

/**
* show storage engines command
*/
public class ShowStorageEnginesCommand extends ShowCommand {
public static final Logger LOG = LogManager.getLogger(ShowStorageEnginesCommand.class);

/**
* constructor
*/
public ShowStorageEnginesCommand() {
super(PlanType.SHOW_STORAGE_ENGINES_COMMAND);
}

/**
* get meta for show tableId
*/
public ShowResultSetMetaData getMetaData() {
ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder();
builder.addColumn(new Column("Engine", ScalarType.createVarchar(64)));
builder.addColumn(new Column("Support", ScalarType.createVarchar(8)));
builder.addColumn(new Column("Comment", ScalarType.createVarchar(80)));
builder.addColumn(new Column("Transactions", ScalarType.createVarchar(3)));
builder.addColumn(new Column("XA", ScalarType.createVarchar(3)));
builder.addColumn(new Column("Savepoints", ScalarType.createVarchar(3)));
return builder.build();
}

private ShowResultSet handleShowEngines(ConnectContext ctx, StmtExecutor executor) throws Exception {
List<List<String>> rowSet = Lists.newArrayList();
rowSet.add(Lists.newArrayList("Olap engine", "YES", "Default storage engine of palo", "NO", "NO", "NO"));
rowSet.add(Lists.newArrayList("MySQL", "YES", "MySQL server which data is in it", "NO", "NO", "NO"));
rowSet.add(Lists.newArrayList("ELASTICSEARCH", "YES", "ELASTICSEARCH cluster which data is in it",
"NO", "NO", "NO"));
rowSet.add(Lists.newArrayList("HIVE", "YES", "HIVE database which data is in it", "NO", "NO", "NO"));
rowSet.add(Lists.newArrayList("ICEBERG", "YES", "ICEBERG data lake which data is in it", "NO", "NO", "NO"));
rowSet.add(Lists.newArrayList("ODBC", "YES", "ODBC driver which data we can connect", "NO", "NO", "NO"));
rowSet.add(Lists.newArrayList("HUDI", "YES", "HUDI data lake which data is in it", "NO", "NO", "NO"));

// Only success
ShowResultSet resultSet = new ShowResultSet(getMetaData(), rowSet);
return resultSet;
}

@Override
public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exception {
return handleShowEngines(ctx, executor);
}

@Override
public <R, C> R accept(PlanVisitor<R, C> visitor, C context) {
return visitor.visitShowStorageEnginesCommand(this, context);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import org.apache.doris.nereids.trees.plans.commands.ShowProcedureStatusCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowRepositoriesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowRolesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowStorageEnginesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowVariablesCommand;
import org.apache.doris.nereids.trees.plans.commands.ShowViewCommand;
import org.apache.doris.nereids.trees.plans.commands.UnsetDefaultStorageVaultCommand;
Expand Down Expand Up @@ -272,6 +273,10 @@ default R visitShowProcCommand(ShowProcCommand showProcCommand, C context) {
return visitCommand(showProcCommand, context);
}

default R visitShowStorageEnginesCommand(ShowStorageEnginesCommand showStorageEnginesCommand, C context) {
return visitCommand(showStorageEnginesCommand, context);
}

default R visitShowCreateMaterializedViewCommand(ShowCreateMaterializedViewCommand showCreateMtlzViewCommand,
C context) {
return visitCommand(showCreateMtlzViewCommand, context);
Expand Down
19 changes: 19 additions & 0 deletions regression-test/data/nereids_p0/show/test_show_engines_nereids.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !cmd_1 --
Olap engine YES Default storage engine of palo NO NO NO
MySQL YES MySQL server which data is in it NO NO NO
ELASTICSEARCH YES ELASTICSEARCH cluster which data is in it NO NO NO
HIVE YES HIVE database which data is in it NO NO NO
ICEBERG YES ICEBERG data lake which data is in it NO NO NO
ODBC YES ODBC driver which data we can connect NO NO NO
HUDI YES HUDI data lake which data is in it NO NO NO

-- !cmd_2 --
Olap engine YES Default storage engine of palo NO NO NO
MySQL YES MySQL server which data is in it NO NO NO
ELASTICSEARCH YES ELASTICSEARCH cluster which data is in it NO NO NO
HIVE YES HIVE database which data is in it NO NO NO
ICEBERG YES ICEBERG data lake which data is in it NO NO NO
ODBC YES ODBC driver which data we can connect NO NO NO
HUDI YES HUDI data lake which data is in it NO NO NO

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_show_engines_nereids") {
checkNereidsExecute("show engines;")
qt_cmd_1("show engines;")
checkNereidsExecute("show storage engines;")
qt_cmd_2("show storage engines;")
// can not use qt to check, the output may change.
}

0 comments on commit d2473ce

Please sign in to comment.