Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for release CD #1

Closed

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Sep 24, 2020

TODO:

@bernt-matthias bernt-matthias force-pushed the topic/singularity-CD branch 2 times, most recently from 6b6553a to c1d972a Compare September 24, 2020 12:55
@halirutan
Copy link
Contributor

@bernt-matthias Your initial intention to install the dfpl directly from the source was a good one! You just missed one important point: You need to map the deepFPlearn directory into the container so that it has read access. To make it work, you'd just need fix the following thing in the singularity def file: Here you remove the package again and put the file system mapping (source -> container destination) in. So since we're calling singularity from the singularity_container directory, it is

.. /deepFPlearn

The parent dir is mapped to /deepFPlearn in the container. Then we can do exactly what you initially had:

/bin/bash -c ". $CONDA_DIR/etc/profile.d/conda.sh; conda activate rdkit2019; python -m pip install /deepFPlearn"

@halirutan
Copy link
Contributor

Alright, I pulled your branch, fixed the singularity built and created a new feat_singularity_CD branch with all additions on this repo.

@mai00fti Can we make Matt a developer of this repository so that we can work together on this?

@halirutan
Copy link
Contributor

halirutan commented Sep 24, 2020

@bernt-matthias OK, check here:

FATAL:   While performing build: 
while creating SIF: while creating container: writing data object for SIF file:
copying data object file to SIF file:
write /__w/deepFPlearn/deepFPlearn/singularity_container/deepFPlearn.sif: no space left on device

What now?

The container builds fine but when finally storing the sif file it runs out of memory. I don't understand why because there seems to be plenty of space

image

@mai00fti
Copy link
Collaborator

@mai00fti Can we make Matt a developer of this repository so that we can work together on this?

done

@halirutan
Copy link
Contributor

@bernt-matthias Let us close this PR and work together on https://github.com/yigbt/deepFPlearn/tree/feat_singularity_CD

@halirutan halirutan closed this Sep 25, 2020
@bernt-matthias
Copy link
Contributor Author

I just took you commits into my branch. I would prefer to keep working on this PR and you push to the branch in my form.

Because leaving the PR also gives us a means of communication.

@halirutan
Copy link
Contributor

Yes, I understand. We open a new WIP PR. The big advantage is that we don't need to pull and push between repos. Give me a second.

@halirutan
Copy link
Contributor

Here you go: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants