Updated Lido integration #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready for review? CI checks are failing, please re-run them and resolve issue if any |
|
@sgzsh269 Can you please help me with debugging the issue with CI? |
can you resolve the merge conflicts and re-run the jobs |
That helped. thanks! |
|
@iamsahu can you please resolve the merge conflicts in your pending PRs, then let me know and will work with you to get all of them merged |
sgzsh269
reviewed
Sep 21, 2023
chat/display_widgets.py
Outdated
| elif command == 'hop-protocol-bridge': | ||
| items = params.split(",") | ||
| lines.append(f"hop protocol bridge action for amount: {items[0]}, token symbol: {items[1]}, from chain: {items[2]}, to chain: {items[3]}.") | ||
| elif command == 'tx-replay': | ||
| items = params.split(",") | ||
| lines.append(f"replay transaction with tx hash: {items[0]}") | ||
| elif command == "deposit-eth-lido": | ||
| params = json.loads(params) | ||
| lines.append(f"deposit eth to lido action for amount: {params['amount']}.") |
There was a problem hiding this comment.
Need to change to look up by list indices instead of param names
sgzsh269
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.