Skip to content

Commit

Permalink
Skip tied weights disk offload test (huggingface#2782)
Browse files Browse the repository at this point in the history
* skip

* fix

* quality

* fix comment
  • Loading branch information
SunMarc authored and yhna940 committed May 16, 2024
1 parent 8033b7e commit 2043207
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tests/test_big_modeling.py
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,12 @@ def forward(self, x):
del model
gc.collect()

# This test fails because sometimes data_ptr() of compute2.weight is the same as compute1.weight.
# I checked that the values are not the same but it gives the same address. This does not happen on my local machine.
@require_cuda
@unittest.skip(
"Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test"
)
def test_dispatch_model_tied_weights_memory_with_nested_offload_disk(self):
# Test that we do not duplicate tied weights at any point during dispatch_model call.

Expand Down

0 comments on commit 2043207

Please sign in to comment.