Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serializable for records one QuarkusTest does not require them #133

Closed
magicDGS opened this issue May 12, 2024 · 3 comments
Closed

Comments

@magicDGS
Copy link
Contributor

On #132, we discovered that records required to be serializable to work with quarkus-tests. This is already reported to quarkus for a long time (see quarkusio/quarkus#15892), but looks like no move have been done in that regard.

We should keep this issue open to simplify our code and remove the serializable class for our enums, as this is a requirement for test-only and should not leak into our actual code.

@magicDGS magicDGS changed the title Remove serializable for records one QuarkusTest does not require the, Remove serializable for records one QuarkusTest does not require them May 19, 2024
@magicDGS
Copy link
Contributor Author

This is already fixed in Quarkus, although not releas is yet done for it. We should keep an eye on it.

@magicDGS
Copy link
Contributor Author

magicDGS commented Jun 3, 2024

Looks like it will be present in quarkus-3.12 (currently only on 3.11). Let's wait to upgrade when it is released

@magicDGS
Copy link
Contributor Author

magicDGS commented Jul 4, 2024

Still in 3.12.1 is not fixed, as the change to JBoss Marshalling was reverted. I added a comment into the original issue and I will open it again if it is not re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant