Add isPagination variable to QueryState, and use for reusing queryId #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new param to QueryState, which is used inside of vertical searches to reuse the previous queryId, if any. It is then set to false, requiring callers to specify every time that the next search is a pagination. J=WAT-4105 TEST=auto wrote new tests
Pull Request Test Coverage Report for Build 9783373596Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9783380261Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9783473559Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9783481782Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9783481149Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9812919264Details
💛 - Coveralls |
EmilyZhang777
approved these changes
Jul 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new param to QueryState, which is used inside of vertical searches to reuse the previous queryId, if any. It is then set to false, requiring callers to specify every time that the next search is a pagination.
J=WAT-4105
TEST=auto
wrote new tests