-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove real live api key #164
Conversation
Pull Request Test Coverage Report for Build 7644357355
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, removing the api key like this won't really help since the repo (and it's past versions) are open source. if security is concerned about these keys getting out, it might be worth looking into whether github has a way to fully redact/delete part of a file, including its past versions
I'm planning on deactivating the api keys, so this change should be sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning on deactivating the api keys, so this change should be sufficient.
would that deactivate the slapshot test account? I find that pretty useful for testing and I believe a lot of our SDKs' test sites are built around the configuration of that experience. it would also be worth checking if the public-facing search-ui-react Storybook site is based off of this experience as well
We could generate a new api key for the account/experience and use that in places needed without deactivate the account/experience itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is a new patch, you'll want to merge into a hotfix branch rather than develop
I'll update search-core first and revisit this PR to include version bump for search-core 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were marking these vulnerabilities as a false positive. do we still need to remove the key?
Yeah, talked to mcgin and confirmed we still want to remove them |
This change removes the real live api key to resolve a vulnerability.
J=VULN-37164
TEST=auto