remove deprecated code #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2876534216Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
juliannzhou
force-pushed
the
dev/delete-headless
branch
from
94c6aa9
to
b444ac1
Compare
nmanu1
reviewed
Aug 18, 2022
nmanu1
approved these changes
Aug 18, 2022
yen-tt
reviewed
Aug 18, 2022
| @@ -29,7 +29,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@reduxjs/toolkit": "^1.8.1", | |||
There was a problem hiding this comment.
before you merge, can we bump the version for this repo as well? I want to publish another alpha version for search-headless
There was a problem hiding this comment.
I will make another PR to bump the version since it's currently alpha.133, but my PR is 132.
There was a problem hiding this comment.
since we already have an alpha for a later PR number, maybe it would make more sense to merge this PR without a version bump and open a new PR for that so the numbering remains consistent
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 8, 2022
## Version 2.0.0 ### Breaking Changes - Re-exported all modified and newly added direct answer related interfaces from search-core V2. (#131 #133 #136 ) - More details of the changes are listed in [search-core v2 release notes](https://github.com/yext/search-core/releases/tag/v2.0.0) - Restructured static filters state to allow user to store more complex combination of static filters as well as field value filters. `SelectableFilter` interface is replaced with `SelectableStaticFilter`, which uses the new `StaticFilter` interface from search-core V2. The static filters state now accepts an array of `SelectableStaticFilter`. (#130 ) - All exports marked as `@deprecated` in previous version(s) as part of a rebranding process is now removed in V2 (#132 ) - for more details, the removed deprecated identifiers are listed in [v1.3 release notes](https://github.com/yext/search-headless/releases/tag/v1.3.0)
Merged
yen-tt
added a commit
that referenced
this pull request
Sep 8, 2022
## Version 2.0.0 ### Breaking Changes - Re-exported all modified and newly added direct answer related interfaces from search-core V2. (#131 #133 #136 ) - More details of the changes are listed in [search-core v2 release notes](https://github.com/yext/search-core/releases/tag/v2.0.0) - Restructured static filters state to allow user to store more complex combination of static filters as well as field value filters. `SelectableFilter` interface is replaced with `SelectableStaticFilter`, which uses the new `StaticFilter` interface from search-core V2. The static filters state now accepts an array of `SelectableStaticFilter`. (#130 ) - All exports marked as `@deprecated` in previous version(s) as part of a rebranding process is now removed in V2 (#132 ) - for more details, the removed deprecated identifiers are listed in [v1.3 release notes](https://github.com/yext/search-headless/releases/tag/v1.3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any code that's marked deprecated as part of renaming and uses the newest alpha of core where all deprecated code is removed.
J=SLAP-2331
TEST=manual
Test: removed code that's tagged deprecated and files named deprecate, updated the documentations, and searched 'deprecate', 'answers', as well as all identifiers in Cindy's renaming prs. Also renamed any deprecated identifiers in past prs that still remain in the document (
AnswersHeadless->SearchHeadless,AnswersCore->SearchCore). Updated to the newest alpha version to confirm any deprecated re-exports are removed.