This repository has been archived by the owner on May 8, 2023. It is now read-only.
Allow piped commands when "stop"ing a server #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
list of arguments will exist. This means that piped commands will not work. This adds support for allowing piped commands for any "stop" command. Note that this does not change the build and launch commands.
theothertomelliott
suggested changes
Dec 2, 2019
| return nil, errors.WithStack(err) | ||
| } | ||
| cmdTokens := commandline.TokenizeCommand(b.Backend.Commands.Stop) | ||
| byteString, err := pipes.RunStrings(cmdTokens...) |
There was a problem hiding this comment.
Could we use AssemblePipes to integrate this into ConstructCommand directly?
Would be nice not to have such differing behavior between the different commands.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ParseCommand assumes that only one command and single
list of arguments will exist. This means that piped commands will
not work. This adds support for allowing piped commands for any
"stop" command.
Note that this does not change the build and launch commands.