Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistence acceptance tests #1224

Merged
merged 16 commits into from
Jan 7, 2021
Merged

Add persistence acceptance tests #1224

merged 16 commits into from
Jan 7, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jan 7, 2021

Add acceptance tests which cover uses of the browser back button and refresh page button

These tests cover the persistence bugs that Christian addressed in #1060. My initial attempt was #1223, however we decided that several of those tests should be integration tests rather than acceptance tests. This PR includes only the tests from #1223 which make sense as acceptance tests.

This PR includes utility functions for refreshing the page and using the back button.

The navigation tab links were incorrectly pointing to './links' rather than './facets' for the Facets page, so I fixed that here as well.

J=SLAP-868
TEST=auto

@cea2aj cea2aj mentioned this pull request Jan 7, 2021
Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lgtm! I like the renames + refactors

@cea2aj cea2aj merged commit 19bf2bc into develop Jan 7, 2021
@cea2aj cea2aj deleted the dev/persistence-tests branch January 7, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants