Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh error due to double encoding in verticalUrl #836

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Refresh error due to double encoding in verticalUrl #836

merged 3 commits into from
Jun 17, 2021

Commits on Jun 16, 2021

  1. Fix error after refresh due to double encoding in verticalUrl 

    - URLSearchParams set() encoded verticalUrl even though it's already encoded since it's extracted from window's URL pathname. updated to append to the param string
- replace() only update the first instance unless a global modifier is used (e.g. this would cause refresh issue on mulilang site for verticalUrl as 'es/help_articles'. updated to replaceAll

J=SLAP-1376
TEST=manual

Launched multilang site with iframe data-path directed to a page with spaces in its names. Confirmed refresh and back/forward nav works accordingly.
    Yen Truong committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    c6a6398 View commit details
    Browse the repository at this point in the history

  2. remove urlSearchParam

    Yen Truong committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    06dee9c View commit details
    Browse the repository at this point in the history

  3. update const

    Yen Truong committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    e047981 View commit details
    Browse the repository at this point in the history