Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Improvements #2391

Merged
merged 7 commits into from
Jan 20, 2022
Merged

Documentation Improvements #2391

merged 7 commits into from
Jan 20, 2022

Conversation

ranile
Copy link
Member

@ranile ranile commented Jan 20, 2022

Description

This PR:

  • Makes the API button direct to correct rustdoc page
  • Adds a tutorial button for better visibility
  • Adds blog

@ranile ranile added this to the v0.20 milestone Jan 20, 2022
@ranile ranile requested review from siku2 and voidpumpkin January 20, 2022 13:37
siku2
siku2 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@siku2 siku2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we really need the blog, but it doesn't hurt to put new releases on there.

@ranile ranile mentioned this pull request Jan 20, 2022
Open
19 tasks
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit ecc1188):

https://yew-rs--pr2391-swizzle-time-kyw0ms5z.web.app

(expires Thu, 27 Jan 2022 13:46:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile
Copy link
Member Author

ranile commented Jan 20, 2022

Don't think we really need the blog, but it doesn't hurt to put new releases on there.

I agree. That's why I added this in #2312:

Add a blog. Even if there won't be frequent posts, a blog post for release sounds good to have.

@ranile
Copy link
Member Author

ranile commented Jan 20, 2022

I'm going to merge this. CI issues are unrelated.

@voidpumpkin Can you look at why benchmark is messing up clippy?

@ranile ranile merged commit a8f7113 into yewstack:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@siku2 siku2 siku2 approved these changes

@voidpumpkin voidpumpkin Awaiting requested review from voidpumpkin

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@ranile @siku2