amendment of todomvc example #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-alik
force-pushed
the
issue-1016-todomvc
branch
from
212c0ed to
e38bc4c
Compare
|
I can't explain why CI build 2113.2 failed. |
|
It’s because of a Clippy (the Rust linter) error.
The error message is:
error: value assigned to `should_update` is never read
--> yew-functional/src/lib.rs:315:25
|
315 | should_update = true;
| ^^^^^^^^^^^^^
|
= note: `-D unused-assignments` implied by `-D warnings`
= help: maybe it is overwritten before being read?
This is weird because you haven’t modified any files inside `yew_functional`. My guess is that it’s because of an update to Clippy which now causes it to spot this error. This isn’t unexpected because Rust 1.45 released yesterday (hoorah!) so the Rust binary for the `stable` (the only check which has failed) release has changed and as a result Clippy has now failed (hope that was clear).
I don’t think this is an issue with this PR.
… On 17 Jul 2020, at 12:47, Алексей Пастухов ***@***.***> wrote:
I can't explain why CI build 2113.2 <https://travis-ci.com/github/yewstack/yew/jobs/362089411#L547> failed.
The previous build 2099 <https://travis-ci.com/github/yewstack/yew/builds/175284375> passed on July 12, 2020 0:10:12
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFSTPKYF5LIFEQDPF3UXCLR4A243ANCNFSM4OXPO5PQ>.
|
|
@Mergifyio rebase |
|
Command |
therustmonk
force-pushed
the
issue-1016-todomvc
branch
from
7c5321b to
86e6117
Compare
|
Needs another rebase to fix tests. Let's see if mergify listens to me... |
|
@Mergifyio rebase |
- makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016
Co-authored-by: Teymour Aldridge <[email protected]>
Co-authored-by: Teymour Aldridge <[email protected]>
Co-authored-by: Teymour Aldridge <[email protected]>
|
Command |
therustmonk
force-pushed
the
issue-1016-todomvc
branch
from
86e6117 to
5a9a8f6
Compare
|
I reckon we should set up Mergify to use a bot account rather than @deniskolodin's account. |
|
@teymour-aldridge Yeah, that's a good idea. |
Haha, yeah, sure! Thank you 🙂👍 |
|
@p-alik Thanks a lot for your contribution! |
teymour-aldridge
added a commit
to teymour-aldridge/yew
that referenced
this pull request
Jul 20, 2020
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> Co-authored-by: Teymour Aldridge <[email protected]>
jstarry
pushed a commit
that referenced
this pull request
Aug 16, 2020
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues #1079 and #1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> Co-authored-by: Teymour Aldridge <[email protected]>
teymour-aldridge
added a commit
to teymour-aldridge/yew
that referenced
this pull request
Sep 1, 2020
* amendment of todomvc example - makes it ready for wasm-pack build mentioned in issues yewstack#1079 and yewstack#1016 * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> * Update examples/todomvc/README.md Co-authored-by: Teymour Aldridge <[email protected]> Co-authored-by: Teymour Aldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes it ready for
wasm-pack buildDescription
as mentioned in issues #1016 wasm-code generated with
wasm-bindgenruns inUncaught SyntaxError: Cannot use 'import.meta' outside a moduleexception. This PR aims to solve the issue by switching towasm-pack. #1079 is an other issue, which referred the example.Checklist:
./ci/run_stable_checks.sh