Fix broken examples (#1289) - batch #1 #1340
Conversation
`python3 -m http.server --directory` flag was added in Python 3.7. Change instructions to cd into static and skip the flag instead - makes it work with earlier Pythons too.
The minimal example has a button, but clicking it does nothing. This makes it hard to tell whether the example works or not. This adds a label that is update when the button is clicked.
* Add a heading to each scene to make it more obvious what the page is for. * Improve layout of input form by stack the inputs vertically. * Add a little space between entries when displaying the list. * Add a hint to the Description input that Markdown can be used.
* Add a second button that demonstrates an unsuccessful fetch. * Render the markdown document (since we're fetching markdown after all). * Remove vague comment that's not really helping.
* Include a textual explanation of what the example is doing.
|
Is there anything else you'd like me to change, @teymour-aldridge ? |
|
If we're happy with this one let's merge it and I'll do another batch of fixes. Looks like the travis build stalled. The jobs themselves ran to completion but the overview thinks they're still in progress? |
|
@numerodix Not sure what's up ith the Travis build but it looks like two were created and only one has suceeded. |
There was a problem hiding this comment.
Looks great, thanks for the clean up @numerodix! And thanks @teymour-aldridge for reviewing this while I was busy 👍
Just one comment 😄
No problem; you do an awesome job maintaining Yew and I'm happy to try and help where I can!
|
|
Really appreciate the fixes @numerodix! |
Description
The first batch of small fixes/improvements to the examples. (See the commit messages for rationale on each individual change.)
At this stage I'm not changing how the
staticdirectory is used and I'm only updating examples that work with the sharedstatic.Given that some examples have/need a custom
staticI'm thinking thatbuild.shmight check inside each example folder to see if there is astaticand if so - use that instead. It could then print instructions on how to run the example (given that it can't be run out of the sharedstatic). This would still allow most examples to share a commonstatic.