Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring scripts fails to install platform-specific esbuild packages #2

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

birdcar
Copy link
Contributor

@birdcar birdcar commented Aug 24, 2023

I'm attempting to resolve an npm build failure while running npm ci, which is thereby causing our test suite to fail.

https://github.com/yettoapp/yetto/actions/runs/5964937468/job/16181260795#step:4:595

After some research, it seems the likely candidate is that we have --ignore-scripts in our npm ci command, which prevents esbuild specifically from installing platform specific dependencies: evanw/esbuild#1819 (comment)

@birdcar birdcar requested a review from gjtorikian August 24, 2023 14:28
@birdcar birdcar merged commit 9eacf5d into main Aug 24, 2023
@birdcar birdcar deleted the fix-npm-ci branch August 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant