Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape original_content #5

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: escape original_content #5

merged 2 commits into from
Aug 15, 2024

Conversation

yuchanns
Copy link
Collaborator

@yuchanns yuchanns commented Aug 15, 2024

str:gsub cannot correctly handle original_content if it contains certain Lua special symbols.

For example:

package main

import "strings"

func main() {
	strings.Replace("https://login.xxx.com/query?redirect=https%3A%2F%2Fxx.com", "%2F", "/", -1)
}

The problematic symbols are %2 and %3.

Let's fix this.

@yetone
Copy link
Owner

yetone commented Aug 15, 2024

‌‌LGTM! There are some code conflicts that need to be resolved.

@yetone yetone merged commit 1634abb into yetone:main Aug 15, 2024
1 check passed
yetone added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants