-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurable history directory #18
Conversation
lua/avante/sidebar.lua
Outdated
elseif type(history_dir) == "function" then | ||
history_dir = history_dir(project_root) | ||
else | ||
history_dir = Path:new(history_dir, project_root:match("([^/]+)$"), ".avante_chat_history") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If placed outside the project_root directory, wouldn't it be impossible to use relative_path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what you want? I'm sorry, but I don't quite understand your meaning.
Rather than making it user-configurable, why don't we implement a more disruptive update (since we're still in early versions) by moving the history directory to the $HOME directory and recording the absolute path? What do you think? |
Says that we have a project under |
For example, my chat history in |
Nevermind. I'll close this PR. Since using shade is better IMO. |
Users should be able to set up a custom history directory.
Also fix #17