Feat: Add support for running Censys queries via analytics #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR for the frontend: yeti-platform/yeti-feeds-frontend#142 |
tomchop
requested changes
Jan 24, 2024
plugins/analytics/public/censys.py
Outdated
| ip_object.tag(query.relevant_tags) | ||
| query.link_to(ip_object, 'censys', f'IP found with Censys query: {query.pattern}') | ||
|
|
||
| def query_censys(self, api, query: str) -> set[str]: |
There was a problem hiding this comment.
Suggested change
| def query_censys(self, api, query: str) -> set[str]: | |
| def query_censys(self, api: CensysHosts, query: str) -> set[str]: |
plugins/analytics/public/censys.py
Outdated
Comment on lines
19
to
22
| hosts_api = CensysHosts( | ||
| api_id=yeti_config.get("censys", "api_key"), | ||
| api_secret=yeti_config.get("censys", "secret") | ||
| ) |
There was a problem hiding this comment.
Please check that these two config settings are set and bail with a warning (logging.warning) if they're not?
There was a problem hiding this comment.
Please give it a ruff formatter pass (We'll add a github action check soon)
tests/analytics_test.py
Outdated
| class AnalyticsTest(unittest.TestCase): | ||
| @classmethod | ||
| def setUpClass(cls) -> None: | ||
| database_arango.db.connect(database="yeti-test") |
There was a problem hiding this comment.
Suggested change
| database_arango.db.connect(database="yeti-test") | |
| database_arango.db.connect(database="yeti_test") |
There was a problem hiding this comment.
Same comment as the other file, please give this a ruff formatter pass
tomchop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Yeti users to add Censys queries as indicators, which will then be ran through the Censys API every 24 hours, tagging the identified IP addresses in Yeti. This will allow for infrastructure tracking/hunting directly from within Yeti.