Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #57 .Env + Readme fixes #58

Merged
merged 39 commits into from
Jan 11, 2024
Merged

fix #57 .Env + Readme fixes #58

merged 39 commits into from
Jan 11, 2024

Conversation

uri-99
Copy link
Collaborator

@uri-99 uri-99 commented Jan 5, 2024

No description provided.

rcatalan98
rcatalan98 requested changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@rcatalan98 rcatalan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just left a few things we should change and take into account. Please be careful with the things we expose in each PR.

.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
contracts/cairo/.env.example Outdated Show resolved Hide resolved
contracts/solidity/test/Transfer.sol Show resolved Hide resolved
mm-bot/.env.example Outdated Show resolved Hide resolved
@uri-99 uri-99 changed the title .Env + Readme fixes fix #57 .Env + Readme fixes Jan 8, 2024
JuArce
JuArce reviewed Jan 8, 2024
View reviewed changes
mm-bot/.env.example Outdated Show resolved Hide resolved
JuArce
JuArce reviewed Jan 9, 2024
View reviewed changes
README.md Show resolved Hide resolved
contracts/cairo/.env.example Show resolved Hide resolved
contracts/solidity/.env.example Outdated Show resolved Hide resolved
@uri-99 uri-99 requested a review from rcatalan98 January 9, 2024 18:44
@uri-99 uri-99 mentioned this pull request Jan 9, 2024
Merged
rcatalan98
rcatalan98 requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@rcatalan98 rcatalan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at some of the comments we left

contracts/cairo/.env.example Outdated Show resolved Hide resolved
contracts/solidity/set_escrow.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
contracts/solidity/deploy.sh Outdated Show resolved Hide resolved
uri-99 and others added 3 commits January 9, 2024 17:58
dubzn
dubzn reviewed Jan 10, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
rcatalan98
rcatalan98 requested changes Jan 10, 2024
View reviewed changes
contracts/cairo/.env.example Outdated Show resolved Hide resolved
contracts/solidity/set_escrow.sh Outdated Show resolved Hide resolved
contracts/solidity/set_withdraw_selector.sh Outdated Show resolved Hide resolved
contracts/solidity/set_withdraw_selector.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rcatalan98
Copy link
Collaborator

I'm getting the following warnings when running make ethereum-deploy:

./contracts/solidity/deploy.sh: line 14: export: #in': not a valid identifier ./contracts/solidity/deploy.sh: line 14: export: 0x': not a valid identifier
\e[32m

rcatalan98
rcatalan98 reviewed Jan 10, 2024
View reviewed changes
README.md Show resolved Hide resolved
Uriel Mihura added 2 commits January 10, 2024 20:29
created make starknet-deploy-and-connect
32abb05 
This commit also adds 2 new .env vars, so that the 3 steps in deploying a starknet contract must have parameter passing between them
Add available herodotus addresses in readme
bc1c61f
dubzn
dubzn reviewed Jan 11, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
rcatalan98
rcatalan98 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@rcatalan98 rcatalan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job this looks way better now

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
JuArce
JuArce reviewed Jan 11, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dubzn
dubzn reviewed Jan 11, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@uri-99 uri-99 merged commit fa473d5 into main Jan 11, 2024
@uri-99 uri-99 deleted the 57-fix-envs branch January 11, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubzn dubzn dubzn left review comments

@JuArce JuArce JuArce left review comments

@taturosati taturosati taturosati approved these changes

@rcatalan98 rcatalan98 rcatalan98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uri-99 @rcatalan98 @JuArce @dubzn @taturosati