Upgrade opn to open (#622)

* Upgrade `opn` to `open`

* Require Node.js 8

.travis.yml

@@ -1,8 +1,8 @@
 language: node_js
 node_js:
+  - 12
   - 10
   - 8
-  - 6
 before_install:
   - npm install --global npm@latest
 after_success:

lib/completion/completer.js

@@ -94,7 +94,7 @@ class Completer {
       const flag = help.flags[key];
 
       if (flag.alias) {
-        alias.push(Object.assign({}, flag, {name: flag.alias}));
+        alias.push({...flag, name: flag.alias});
       }
 
       flag.name = key;

lib/routes/help.js

@@ -1,6 +1,6 @@
 'use strict';
 const inquirer = require('inquirer');
-const opn = require('opn');
+const open = require('open');
 
 module.exports = app => {
   app.insight.track('yoyo', 'help');
@@ -31,6 +31,6 @@ module.exports = app => {
       return;
     }
 
-    opn(answer.whereTo);
+    open(answer.whereTo);
   });
 };

package.json

@@ -12,7 +12,7 @@
     "yo-complete": "lib/completion/index.js"
   },
   "engines": {
-    "node": ">=6"
+    "node": ">=8"
   },
   "scripts": {
     "postinstall": "yodoctor",
@@ -57,7 +57,7 @@
     "lodash": "^4.17.10",
     "meow": "^3.0.0",
     "npm-keyword": "^5.0.0",
-    "opn": "^5.3.0",
+    "open": "^6.3.0",
     "package-json": "^5.0.0",
     "parse-help": "^1.0.0",
     "read-pkg-up": "^4.0.0",
@@ -108,6 +108,9 @@
           "mocha"
         ]
       }
-    ]
+    ],
+    "rules": {
+      "promise/prefer-await-to-then": 0
+    }
   }
 }

test/route-help.js

@@ -12,9 +12,9 @@ describe('help route', () => {
     this.homeRoute = sinon.spy();
     this.router = new Router(sinon.stub(), this.insight);
     this.router.registerRoute('home', this.homeRoute);
-    this.opn = sinon.stub();
+    this.open = sinon.stub();
     const helpRoute = proxyquire('../lib/routes/help', {
-      opn: this.opn
+      open: this.open
     });
     this.router.registerRoute('help', helpRoute);
   });
@@ -42,8 +42,8 @@ describe('help route', () => {
     const url = 'http://yeoman.io';
     this.sandbox.stub(inquirer, 'prompt').returns(Promise.resolve({whereTo: url}));
     return this.router.navigate('help').then(() => {
-      sinon.assert.calledWith(this.opn, url);
-      sinon.assert.calledOnce(this.opn);
+      sinon.assert.calledWith(this.open, url);
+      sinon.assert.calledOnce(this.open);
     });
   });
 });