Skip duplicate configurations.

[boushley]

This should resolve #289.

This also detects a bad configuration where multiple blocks attempt to write
to the same destination with different sources.

I realize #324 is already a PR for this, but the method taken in that PR is O(n^2) and this avoids that extra looping. This PR also has tests.

[XhmikosR]

/CC @yeoman/yeoman-contributors

This seems to be in better shape compared to #324. Can someone review this?

[sindresorhus]

@XhmikosR i don't have enough comprehension of the codebase to be able to judge this, but I trust your judgement.

[boushley]

@XhmikosR @sindresorhus It looks like this has been chosen in favor of the alternate PR. What else needs to happen for this to land?

Anything I can do to help move this forward?

[sindresorhus]

Landed. Thanks @boushley :)

[sindresorhus]

Published as 2.3.0

[boushley]

Thanks!
On Jun 26, 2014 5:10 PM, "Sindre Sorhus" [email protected] wrote:

Published as 2.3.0

—
Reply to this email directly or view it on GitHub
#382 (comment).

[htanjo]

Awesome! This works perfectly in my project.
Thanks!

[schmod]

This is great. Thanks for the PR.

In the interest of keeping things DRY, is there a better way to manage "multi-page" apps with usemin?

While the error-checking in this version is greatly appreciated, it'd be even better if we didn't have to carefully keep all of our blocks in sync.

Some options might be:

• Declare our blocks in a partial, and splice it into the main HTML before useminPrepare runs. (Cons: Makes localhost testing difficult)
• Add a configuration option to merge file lists when we specify multiple build targets with the same name (Cons: Could be unpredictable)

[boushley]

@schmod That's actually exactly what I am doing. I'm using Metalsmith as a static site generator. I have a partial that lists the script block to be included on each page. It gets rebuilt quickly so local development is still speedy, and I'm not trying to ensure multiple blocks are in sync.

I added the code here that ensures that they are the same, just to be sure people didn't accidentally define blocks that would cause a weird and confusing bug when trying to debug it.

[albertpeiro]

I'm not sure I have the same use case but here's the issue I'm facing, very related to this:

index.html:

<!-- build:css(.tmp) styles/index.css -->
    <link rel="stylesheet" href="styles/main.css">
<!-- endbuild -->

signin.html

<!-- build:css(.tmp) styles/signin.css -->
    <link rel="stylesheet" href="styles/main.css">
    <link rel="stylesheet" href="styles/signin.css">
<!-- endbuild -->

Now my just scaffolded app gruntfile:

useminPrepare: {
      html: {
        src: ['<%= yeoman.app %>/index.html']
      },
  options: {
    dest: '<%= yeoman.dist %>',
    flow: {
      html: {
        steps: {
          js: ['concat', 'uglifyjs'],
          css: ['cssmin']
        },
        post: {}
      },
    }
  }
},

A few months ago (latest version) I could modify useminPrepare to:

  useminPrepare: {
        options: {
            dest: '<%= config.dist %>'
        },
        html: '<%= config.app %>/{index,signin}.html'
    },

And it would generate index.12345.css and signin.12345.css and correctly replace them in the .html files as needed. This doesn't work anymore and it throws me:

Fatal error: Different sources attempting to write to the same destination:
 {
     "dest": "dist/styles/vendor.css",
     "src": [
         "bower_components/bootstrap/dist/css/bootstrap.css"
     ]
 }
   {
     "files": []
 }

How can I achieve this with the newest version? Thank you.

[richardwestenra]

+1. I'm using generator-jekyllrb with custom designs for different pages but with shared main.css, modernizr.js and main.js files across the site. After updating, I'm finding that it will no longer let me scan multiple html files to find all the custom css/js files:

useminPrepare: {
  options: {
    dest: '<%= yeoman.dist %>'
  },
  html: '<%= yeoman.dist %>/**/*.html'
},

If I can't get it to scan all the html files and ignore duplicates, is there any way to bypass useminprepare and manually tell it which files to use?

The way I'm doing it at the moment is to create a throwaway userminprepare.html file which just contains references to all of my js/css, and I run useminprepare on it before deleting it with the clean task when deploying. It works and it's fast but it's not very DRY.

[plrthink]

+1. Is there some updates?

[mCarini86]

+1 Any Update?

[ruyadorno]

@plrthink @mCarini86 we just got PR #496 in time for the v3.0.0 release, with this new version it should be possible to use the --force option and have usemin working with duplicate blocks like before.

This fixed my use case, similar to what @richardwestenra described (sharing main.css across multiple html pages), the only downside is that I have to use the force option now...