This repository has been archived by the owner on May 25, 2019. It is now read-only.
Make the bootstrap font path relative #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Bootstrap font path only works for projects in root directories. I recommend making the path relative instead of absolute so that it will also work when projects are deployed to subdirectories.
|
👍 |
|
@richardwestenra, your review of #343 would be most welcome 👍 |
|
@stephenplusplus Sure. Both the "../bower_components" path (as used on #342) and the "../../bower_components" path (as used on #343) work equally well when serving the app locally. However it only works on a dist build when you use the single ../. It'd be worth a look from someone more experienced with Yeoman: I'm still relatively new to it. |
kevva
added a commit
that referenced
this pull request
Apr 16, 2014
closes #342 - remove loadPath & includePath.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Bootstrap font path only works for projects in root directories. I recommend making the path relative instead of absolute so that it will also work when projects are deployed to subdirectories.