Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

fix(app): order of script inclusions #286

Merged
merged 1 commit into from
Jul 24, 2013
Merged

Conversation

passy
Copy link
Member

@passy passy commented Jul 20, 2013

Fixes #278

The application JS is now included as last element in the index.html, specifically after any plugins. As a consequence, the subgenerators append their own snippets in the same block.

Plugins should be loaded before the application JS.

Fixes yeoman#278
@passy
Copy link
Member Author

passy commented Jul 24, 2013

@stephenplusplus Would you mind taking a look? You had some trouble with dep ordering too, hadn't you?

@stephenplusplus
Copy link
Contributor

Hmm, I hope I didn't originally break this! Tested, and this fix looks 👍

passy added a commit that referenced this pull request Jul 24, 2013
fix(app): order of script inclusions
@passy passy merged commit 2eaa05f into yeoman:master Jul 24, 2013
@passy
Copy link
Member Author

passy commented Jul 24, 2013

@stephenplusplus Thanks! 💃

stevemao pushed a commit to stevemao/generator-angular that referenced this pull request Nov 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If we choose to use any angular-*.js file, all files generated afterwards are included on the wrong group.
2 participants