Update bin-version-check package not to use cross-spaws-async package.

[silverskyvicto]

When installing yeoman using npm, I get the following warning:

npm WARN deprecated [email protected]: cross-spawn no longer requires a build toolchain, use it instead

This is due to the old bin-version-check package, which is doctor's dependent library, so it can be resolved by using a newer version.

How about it?

$ npm install -g yo
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: cross-spawn no longer requires a build toolchain, use it instead
<User home directory>/.nodebrew/node/v12.16.2/bin/yo -> <User home directory>/.nodebrew/node/v12.16.2/lib/node_modules/yo/lib/cli.js
<User home directory>/.nodebrew/node/v12.16.2/bin/yo-complete -> <User home directory>/.nodebrew/node/v12.16.2/lib/node_modules/yo/lib/completion/index.js

> [email protected] postinstall <User home directory>/.nodebrew/node/v12.16.2/lib/node_modules/yo/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)


> [email protected] postinstall <User home directory>/.nodebrew/node/v12.16.2/lib/node_modules/yo/node_modules/ejs
> node ./postinstall.js

Thank you for installing EJS: built with the Jake JavaScript build tool (https://jakejs.com/)


> [email protected] postinstall <User home directory>/.nodebrew/node/v12.16.2/lib/node_modules/yo/node_modules/spawn-sync
> node postinstall


> [email protected] postinstall <User home directory>/.nodebrew/node/v12.16.2/lib/node_modules/yo
> yodoctor


Yeoman Doctor
Running sanity checks on your system

✔ No .bowerrc file in home directory
✔ Global configuration file is valid
✔ NODE_PATH matches the npm root
✔ No .yo-rc.json file in home directory
✔ Node.js version
✔ npm version
✔ yo version

Everything looks all right!
+ [email protected]
added 684 packages from 392 contributors in 21.82s

[LitoMore]

@silverskyvicto The error name has been changed to InvalidBinaryVersion in [email protected].

This code below should be updated:

doctor/lib/rules/yo-version.js

Line 21 in 3a3689c

if (error.name === 'InvalidBinVersion') {

[LitoMore]

By the way, could you add test for this? I would be better if we can cover the catch statement.

[silverskyvicto]

@LitoMore
I added one test and it seems that I was able to test the error of the pattern that is not InvalidBinaryVersion, so I will reflect this as well.

[LitoMore]

ping @SBoudrias

[silverskyvicto]

@LitoMore
It's been a long time since I submitted this pull request, has it not gone through review?

[silverskyvicto]

Related Issue: #49