#239 PsLinkedin passes the request parameters to the URI.

[super132]

For task #239, removing request parameters in Href object and move them into body.

[super132]

@davvd , this is fix for #239, please review. Thanks.

[davvd]

@super132 Thanks, let me find someone who can review this pull request

[davvd]

@caarlos0 please review, thanks

[caarlos0]

@super132 can you write some test?

[super132]

@caarlos0, I can write some tests but now there is no test for PsLinkedin and there is puzzle for it. Does it mean that I need to solve it together with that puzzle? Thanks.

[caarlos0]

@super132 oh, if there is a puzzle already, I think we are good to go here..

[caarlos0]

@rultor good to merge

[rultor]

@rultor good to merge

@caarlos0 Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@super132 @caarlos0 no, we're not good to go. we should wait for that puzzle resolution and then proceed here with a unit test

[super132]

@yegor256 @caarlos0 understood. Let's wait for #158 to be resolved in order to add a test. Thanks.

[caarlos0]

@yegor256 @super132 makes sense.

[caarlos0]

@davvd we are waiting for #158 here.

[davvd]

@davvd we are waiting for #158 here.

@caarlos0 sure, let's wait for #158

[davvd]

@super132 #158 is closed, it was an impediment

[super132]

@caarlos0 I have amended the login test case to check for request body and URL. Please have a look. Thanks.

[caarlos0]

@super132 looks good.

[caarlos0]

@rultor good to merge

[rultor]

@rultor good to merge

@caarlos0 Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@super132 I would rather use RqPrint(req).printBody()

[yegor256]

@super132 there is a better/shorter way to do what you're doing, see above

[super132]

@yegor256 thanks for you advice. I have amended it using RqPrint, please take a look. Thanks.

[yegor256]

@super132 don't you think that String.format() is more suitable here? see http://www.yegor256.com/2014/06/19/avoid-string-concatenation.html

[yegor256]

@super132 one more comment, see above

[super132]

@yegor256 right, it would be cleaner to use String.format() instead. I have revised the code. Thanks.

[yegor256]

@rultor try to merge

[rultor]

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 12min)

[davvd]

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

[davvd]

@rultor deploy now pls

[rultor]

@rultor deploy now pls

@davvd OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy now pls

@davvd Done! FYI, the full log is here (took me 10min)

[elenavolokhova]

@caarlos0
According to our quality rules:

The code reviewer found at least three problems in the code.

Please confirm that you will try to find at least three problems next time.

[caarlos0]

@elenavolokhova Yes, I'll try

[elenavolokhova]

@davvd Quality is acceptable here.

[davvd]

@davvd Quality is acceptable here.

@elenavolokhova thanks, got it. everybody, please try to make it good next time

[davvd]

@caarlos0 just added 10 mins to @elenavolokhova (for QA), payment ID is 57255929; paid, thanks, added 23 mins to your account, payment AP-1JP12351VU9246113, 21 hours and 55 mins was spent; extra minutes for review comments (c=8); added +23 to your rating, now it is equal to +1952